Add Settings button and Test field to Main activity #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some configurations, you don't have the Settings key on the keyboard and then it is hard to find the settings. One might look for it in the Main application of Hacker's Keyboard, but there it is not. This commit adds a "Settings" button there.
This allows fast testing of the keyboard after changing settings. It is also nice that it fills the 3rd row of the table.
Android Studio shows up warnings about empty XML bodies when using <Foo bar="23"></Foo> instead of <Foo bar="23" />
|
I'd like to add that a FlowLayout would probably be a better choice than the currently used TableLayout to arrange the buttons and the Test field. In vertical mode, it would look the same (except for the Test field), but in horizontal mode it would all fit on one line which is probably better. However, I did not touch this in this pull request and simply kept the TableLayout. |
|
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to change the settings of the
keyboard and test it.